Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finally in empty chains of responsibility #29

Merged
merged 12 commits into from
Nov 10, 2024

Conversation

mariusz96
Copy link
Contributor

@mariusz96 mariusz96 commented Oct 26, 2024

The PR for #28. Also includes the previous PR for #26.

@mariusz96 mariusz96 changed the title Should chains of responsibility run finally when empty? Fix finally in empty chains of responsibility Oct 27, 2024
Copy link
Owner

@ipvalverde ipvalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@@ -92,18 +92,41 @@ public async Task<TReturn> Execute(TParameter parameter) =>
public async Task<TReturn> Execute(TParameter parameter, CancellationToken cancellationToken)
{
if (MiddlewareTypes.Count == 0)
return default(TReturn);
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this get merged, the behavior change should be noted in release notes or somewhere else.

@mariusz96
Copy link
Contributor Author

All merged.

@ipvalverde ipvalverde merged commit a43043d into ipvalverde:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants